[dpdk-dev] [PATCH v2 10/12] mk: install examples

Panu Matilainen pmatilai at redhat.com
Thu Dec 3 14:35:47 CET 2015


On 12/03/2015 03:32 PM, Thomas Monjalon wrote:
> 2015-12-03 15:19, Panu Matilainen:
>> On 12/03/2015 07:02 AM, Thomas Monjalon wrote:
>>> The examples are part of the installed documentation.
>>>
>>> Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
>>> ---
>>>    mk/rte.sdkinstall.mk | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk
>>> index 902a933..13fa819 100644
>>> --- a/mk/rte.sdkinstall.mk
>>> +++ b/mk/rte.sdkinstall.mk
>>> @@ -154,3 +154,4 @@ ifneq ($(wildcard $O/doc/*/*/*pdf),)
>>>    	$(Q)$(call rte_mkdir,     $(DESTDIR)$(docdir)/guides)
>>>    	$(Q)cp -a $O/doc/*/*/*pdf $(DESTDIR)$(docdir)/guides
>>>    endif
>>> +	$(Q)cp -a $(RTE_SDK)/examples $(DESTDIR)$(datadir)
>>>
>>
>> If examples are considered documentation (and I agree on that), then
>> shouldn't they be installed in $(docdir) instead?
>
> I was hesitating. I think it's strange to install some code in
> /usr/share/doc/.
> It's not really important and may be changed easily at any time.
>

Installing source code anywhere at all seems a bit strange, being in doc 
seems like the least-worst alternative to me :) But like said, no big deal.

	- Panu -


More information about the dev mailing list