[dpdk-dev] [PATCH] examples/vhost: reduce number of hugepages needed

[Yuanhan Liu]

On Thu, Dec 10, 2015 at 01:26:14PM +0000, Iremonger, Bernard wrote:
> Hi Yuanhan,
> 
> <snip>
> 
> > >  /*-
> > >   *   BSD LICENSE
> > >   *
> > > - *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> > > + *   Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
> > >   *   All rights reserved.
> > >   *
> > >   *   Redistribution and use in source and binary forms, with or without
> > > @@ -53,7 +53,8 @@
> > >
> > >  #include "main.h"
> > >
> > > -#define MAX_QUEUES 512
> > > +/* decrease MAX_QUEUES from 512 to reduce number of hugepages
> > needed
> > > +*/
> > 
> > Minor nit: I would suggest to simply remove this comment, which might be a
> > bit confusing without the content (that 512 would let vhost-switch fail to start
> > if given memory is small).
> > 
> > Otherwise, this patch looks good to me.
> > 
> > Acked-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>
> > 
> > Thanks.
> > 
> > 	--yliu
> > 
> <snip>
> 
> I will remove the comment.
> Can I keep your ack.

Thanks and sure, you can always keep one's ACK if you just need fix
some minor nits when he has already given the ack.

	--yliu