[dpdk-dev] [PATCH] i40e: fix unintended sign extension

Mcnamara, John john.mcnamara at intel.com
Tue Dec 15 18:01:17 CET 2015


> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jingjing Wu
> Sent: Tuesday, December 15, 2015 4:23 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] i40e: fix unintended sign extension
> 
> Coverity issue reported like
> CID 119268 (#1 of 1): Unintended sign extension
> (SIGN_EXTENSION)sign_extension: Suspicious implicit sign extension:
> vsi_id with type unsigned short (16 bits, unsigned) is promoted in vsi_id
> << 23 to type int (32 bits, signed), then sign-extended to type unsigned
> long (64 bits, unsigned). If vsi_id << 23 is greater than 0x7FFFFFFF, the
> upper bits of the result will all be 1.
> 
> Fixes: 88ebc2b7f976 ("i40e: extend flow director to support VF")
> Signed-off-by: Jingjing Wu <jingjing.wu at intel.com>

Acked-by: John McNamara <john.mcnamara at intel.com>



More information about the dev mailing list