[dpdk-dev] [PATCH] virtio: fix crashes in virtio stats functions

Yuanhan Liu yuanhan.liu at linux.intel.com
Thu Dec 24 04:48:41 CET 2015


On Wed, Dec 23, 2015 at 09:45:19AM +0000, Bernard Iremonger wrote:
> This initialisation of nb_rx_queues and nb_tx_queues has been removed
> from eth_virtio_dev_init.
> 
> The nb_rx_queues and nb_tx_queues were being initialised in eth_virtio_dev_init
> before the tx_queues and rx_queues arrays were allocated.
> 
> The arrays are allocated when the ethdev port is configured and the
> nb_tx_queues and nb_rx_queues are initialised.
> 
> If any of the following functions were called before the ethdev
> port was configured there was a segmentation fault because
> rx_queues and tx_queues were NULL:
> 
> rte_eth_stats_get
> rte_eth_stats_reset
> rte_eth_xstats_get
> rte_eth_xstats_reset
> 
> Fixes: 823ad647950a ("virtio: support multiple queues")
> Signed-off-by: Bernard Iremonger <bernard.iremonger at intel.com>

Acked-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>

Thanks.

	--yliu


More information about the dev mailing list