[dpdk-dev] [PATCH v2 1/3] app/test-pmd: Handle SIGINT and SIGTERM in testpmd

Wang, Zhihong zhihong.wang at intel.com
Mon Dec 28 02:37:44 CET 2015


> > -	cl = cmdline_stdin_new(main_ctx, "testpmd> ");
> > -	if (cl == NULL) {
> > +	testpmd_cl = cmdline_stdin_new(main_ctx, "testpmd> ");
> > +	if (testpmd_cl == NULL) {
> >  		return;
> >  	}
> 
> Style nit: don't need {} around single statement.
> 
> > +static void
> > +sigint_handler(__rte_unused int signum) {
> > +	if (signum == SIGINT || signum == SIGTERM) {
> 
> signmum is used, so don't want __rte_unused
> 

Thanks :) Will fix these in the next version.



More information about the dev mailing list