[dpdk-dev] [PATCH 00/18] lib/librte_pmd_fm10k : fm10k pmd driver

Chen, Jing D jing.d.chen at intel.com
Mon Feb 2 09:55:04 CET 2015


Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Monday, February 02, 2015 4:20 PM
> To: Chen, Jing D
> Cc: Shaw, Jeffrey B; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 00/18] lib/librte_pmd_fm10k : fm10k pmd
> driver
> 
> 2015-02-02 02:59, Chen, Jing D:
> > Hi,
> >
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> > > 2015-01-30 13:46, Jeff Shaw:
> > > > On Fri, Jan 30, 2015 at 04:26:33PM -0500, Neil Horman wrote:
> > > > > On Fri, Jan 30, 2015 at 01:07:16PM +0800, Chen Jing D(Mark) wrote:
> > > > > > From: "Chen Jing D(Mark)" <jing.d.chen at intel.com>
> > > > > > Jeff Shaw (18):
> > > > > >   fm10k: add base driver
> > > [...]
> > > > > >  lib/librte_pmd_fm10k/SHARED/fm10k_api.c         |  327 ++++
> > > [...]
> > > > >
> > > > > Why is there a SHARED directory in the driver?  Are there other
> drivers
> > > that use
> > > > > the shared fm10k code?
> > > >
> > > > No, the other poll-mode drivers do not use the shared fm10k code. The
> > > > directory is similar to the 'ixgbe' and 'i40e' directories in their
> > > > respective PMDs, only that it is named 'SHARED' for the fm10k driver.
> > >
> > > So shared is a bad name in the context of DPDK.
> > > Inside Intel, it can be understood that you share it between projects,
> > > but in DPDK, it's only a base driver.
> > >
> >
> > OK, I'll change "SHARED" to "fm10k".
> 
> I think that "base" would be more appropriate:
> fm10K/base instead of fm10k/fm10k.

No problem.

> 
> --
> Thomas

Best Regards,
Mark


More information about the dev mailing list