[dpdk-dev] [PATCH 3/6] bsd: remove useless assignments
Bruce Richardson
bruce.richardson at intel.com
Mon Feb 16 12:31:12 CET 2015
On Sat, Feb 14, 2015 at 09:59:07AM -0500, Stephen Hemminger wrote:
> If variable is set in the next line, it doesn't need to be
> initialized.
>
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
> lib/librte_eal/bsdapp/eal/eal.c | 3 ++-
> lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
> index 69f3c03..71ae33c 100644
> --- a/lib/librte_eal/bsdapp/eal/eal.c
> +++ b/lib/librte_eal/bsdapp/eal/eal.c
> @@ -417,7 +417,8 @@ int rte_eal_has_hugepages(void)
> int
> rte_eal_iopl_init(void)
> {
> - int fd = -1;
> + int fd;
> +
> fd = open("/dev/io", O_RDWR);
Why not just merge the two lines and make it "int fd = open(...);".
/Bruce
More information about the dev
mailing list