[dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB)

Jastrzebski, MichalX K michalx.k.jastrzebski at intel.com
Thu Feb 19 10:18:26 CET 2015


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, February 18, 2015 8:10 PM
> To: Doherty, Declan; Jastrzebski, MichalX K
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB)
> 
> Hi,
> 
> 2015-02-13 16:12, Declan Doherty:
> > On 13/02/15 15:16, Michal Jastrzebski wrote:
> > > Michal Jastrzebski (6):
> > >    net: changed arp_hdr struct declaration
> > >    bond: add link bonding mode 6 implementation
> > >    bond: add debug info for mode 6 link bonding
> > >    bond: add example application for link bonding mode 6
> > >    bond: modify TLB unit tests
> > >    bond: add unit tests for link bonding mode 6.
> 
Hi Thomas,
> You didn't sign some of these patches. So I suspect that you should
> fix some authorship.
That's because I am not an author of all of these patches - 1/6, 5/6 and 6/6
> 
> Some of the patches make some changes without explaining why.
I noticed 5/6 has got incomplete description. Probably it disappeared during edition.
> 
> > Series Acked-by: Declan Doherty <declan.doherty at intel.com>
> 
> Please, use checkpatch before submitting and/or when reviewing.
I was using checkptach.pl, and have no errors, but I will check again.
Maybe I overlooked something.
> 
> A v3 is needed.

Best regards
Michal


More information about the dev mailing list