[dpdk-dev] [PATCH v2 5/7] rte_sched: don't put tabs in log messages

Dumitrescu, Cristian cristian.dumitrescu at intel.com
Fri Feb 20 19:33:09 CET 2015



> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen
> Hemminger
> Sent: Thursday, February 5, 2015 6:14 AM
> To: dev at dpdk.org
> Cc: Stephen Hemminger
> Subject: [dpdk-dev] [PATCH v2 5/7] rte_sched: don't put tabs in log
> messages
> 
> From: Stephen Hemminger <shemming at brocade.com>
> 
> syslog does not like tabs in log messages; tab gets translated to #011
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
>  lib/librte_sched/rte_sched.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
> index d891e50..55fbc14 100644
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> @@ -495,10 +495,10 @@ rte_sched_port_log_pipe_profile(struct
> rte_sched_port *port, uint32_t i)
>  	struct rte_sched_pipe_profile *p = port->pipe_profiles + i;
> 
>  	RTE_LOG(INFO, SCHED, "Low level config for pipe profile %u:\n"
> -		"\tToken bucket: period = %u, credits per period = %u, size =
> %u\n"
> -		"\tTraffic classes: period = %u, credits per period = [%u, %u,
> %u, %u]\n"
> -		"\tTraffic class 3 oversubscription: weight = %hhu\n"
> -		"\tWRR cost: [%hhu, %hhu, %hhu, %hhu], [%hhu, %hhu,
> %hhu, %hhu], [%hhu, %hhu, %hhu, %hhu], [%hhu, %hhu, %hhu, %hhu]\n",
> +		"    Token bucket: period = %u, credits per period = %u, size =
> %u\n"
> +		"    Traffic classes: period = %u, credits per period = [%u, %u,
> %u, %u]\n"
> +		"    Traffic class 3 oversubscription: weight = %hhu\n"
> +		"    WRR cost: [%hhu, %hhu, %hhu, %hhu], [%hhu, %hhu,
> %hhu, %hhu], [%hhu, %hhu, %hhu, %hhu], [%hhu, %hhu, %hhu, %hhu]\n",
>  		i,
> 
>  		/* Token bucket */
> @@ -716,9 +716,9 @@ rte_sched_port_log_subport_config(struct
> rte_sched_port *port, uint32_t i)
>  	struct rte_sched_subport *s = port->subport + i;
> 
>  	RTE_LOG(INFO, SCHED, "Low level config for subport %u:\n"
> -		"\tToken bucket: period = %u, credits per period = %u, size =
> %u\n"
> -		"\tTraffic classes: period = %u, credits per period = [%u, %u,
> %u, %u]\n"
> -		"\tTraffic class 3 oversubscription: wm min = %u, wm max =
> %u\n",
> +		"    Token bucket: period = %u, credits per period = %u, size =
> %u\n"
> +		"    Traffic classes: period = %u, credits per period = [%u, %u,
> %u, %u]\n"
> +		"    Traffic class 3 oversubscription: wm min = %u, wm max =
> %u\n",
>  		i,
> 
>  		/* Token bucket */
> --
> 2.1.4

Acked by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>

--------------------------------------------------------------
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.




More information about the dev mailing list