[dpdk-dev] [PATCH v6 0/7] rte_hash_crc reworked to be platform-independent
Thomas Monjalon
thomas.monjalon at 6wind.com
Mon Feb 23 18:36:57 CET 2015
2015-02-19 15:21, Bruce Richardson:
> Confirmed, this worked for me too.
> Looking at the patches, they look good. However, one thing I think we are missing
> is a unit test to verify that all our CRC implementations give the same result.
> That would be useful as a sanity check of the software fallback especially. The
> existing hash tests, test the hash table implementation rather than the
> mathematical argorithm used to compute the hash values.
>
> Overall, though, software fallback for CRC is something well worthwhile having.
>
> Series Acked-by: Bruce Richardson <bruce.richardson at intel.com>
Applied, thanks
Note: running doxygen compilation helped me to find and fix a small
mismatch (parameter alg was flag in comment).
More information about the dev
mailing list