[dpdk-dev] [PATCH v4 12/18] app/test: Remove useless code

Gajdzica, MaciejX T maciejx.t.gajdzica at intel.com
Fri Feb 27 17:01:08 CET 2015


> Severl useless code lines are added accidenly, which blocks packet type
> unification. They should be deleted at all.
> 
> Signed-off-by: Helin Zhang <helin.zhang at intel.com>
> ---
>  app/test/packet_burst_generator.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> v4 changes:
> * Removed several useless code lines which block packet type unification.
> 
> diff --git a/app/test/packet_burst_generator.c
> b/app/test/packet_burst_generator.c
> index b46eed7..b9f8f1a 100644
> --- a/app/test/packet_burst_generator.c
> +++ b/app/test/packet_burst_generator.c
> @@ -272,19 +272,9 @@ nomore_mbuf:
>  		if (ipv4) {
>  			pkt->vlan_tci  = ETHER_TYPE_IPv4;
>  			pkt->l3_len = sizeof(struct ipv4_hdr);
> -
> -			if (vlan_enabled)
> -				pkt->ol_flags = PKT_RX_IPV4_HDR |
> PKT_RX_VLAN_PKT;
> -			else
> -				pkt->ol_flags = PKT_RX_IPV4_HDR;
>  		} else {
>  			pkt->vlan_tci  = ETHER_TYPE_IPv6;
>  			pkt->l3_len = sizeof(struct ipv6_hdr);
> -
> -			if (vlan_enabled)
> -				pkt->ol_flags = PKT_RX_IPV6_HDR |
> PKT_RX_VLAN_PKT;
> -			else
> -				pkt->ol_flags = PKT_RX_IPV6_HDR;
>  		}
> 
>  		pkts_burst[nb_pkt] = pkt;
> --
> 1.9.3

Acked-by: Maciej Gajdzica <maciejx.t.gajdzica at intel.com>


More information about the dev mailing list