[dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Mon Jan 19 10:14:21 CET 2015



> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of David Marchand
> Sent: Monday, January 19, 2015 7:21 AM
> To: Zhang, Helin
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] Fix rte_is_power_of_2
> 
> Hello,
> 
> On Mon, Jan 19, 2015 at 3:45 AM, Zhang, Helin <helin.zhang at intel.com>
> wrote:
> 
> > It seems that your fix result in cannot launching applications.
> > I don't suspect the correction of your fix, but somewhere else needs to be
> > corrected together with your fix.
> >
> > Logs:
> >
> /**********************************************************
> **
> > RING: Cannot reserve memory for tailq
> >
> 
> I have a quick fix for this one (rte_malloc_socket refuses 0 alignment),
> but looking at the change, I would say there are a lot of places to be
> checked.
> Were those places checked during review ?
> 
> Kerur, did you run a make test ?
> All tests fail for me because of rte_malloc_socket.

I think this is already fixed by Declan in his last patch.

Pablo

> 
> 
> --
> David Marchand


More information about the dev mailing list