[dpdk-dev] [PATCH v1 09/15] malloc: fix the issue of SOCKET_ID_ANY

Stephen Hemminger stephen at networkplumber.org
Mon Jan 26 14:48:09 CET 2015


On Thu, 22 Jan 2015 16:16:32 +0800
Cunming Liang <cunming.liang at intel.com> wrote:

> -	return rte_socket_id();
> +	unsigned socket_id = rte_socket_id();
> +
> +	if (socket_id == (unsigned)SOCKET_ID_ANY)

I prefer not casting -1 to unsigned it will cause warnings.
It is better to make socket_id an integer and then have
the implicit cast in the return


More information about the dev mailing list