[dpdk-dev] [PATCH v2] test: fix missing NULL pointer checks
Thomas Monjalon
thomas.monjalon at 6wind.com
Tue Jan 27 15:21:53 CET 2015
2015-01-27 15:17, Daniel Mrzyglod:
> In test_sched, we are missing NULL pointer checks after calls to create the
> mempool and to allocate an mbuf. Add in these checks using TEST_ASSERT_NOT_NULL macros.
You are adding checks *and* replacing VERIFY by TEST_ASSERT_NOT_NULL.
It would be better to explain why you do these replacements.
Please don't forget to answer the "why" question in the commit logs.
Thanks
--
Thomas
More information about the dev
mailing list