[dpdk-dev] [PATCH v3 5/8] ring: queue stats mapping set dummy implementation
Thomas Monjalon
thomas.monjalon at 6wind.com
Thu Jul 9 03:58:02 CEST 2015
2015-06-29 16:50, Tomasz Kulasek:
> Per queue statistics are already implemented for ring device, but with
> static mapping (stat_idx == queue_id).
>
> This fix is required, if you want to use ring device in test application
> and is used only to point that per queue statistics are provided for this
> device.
>
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek at intel.com>
[...]
> +static int
> +eth_queue_stats_mapping_set(__rte_unused struct rte_eth_dev *dev,
> + __rte_unused uint16_t queue_id, __rte_unused uint8_t stat_idx,
> + __rte_unused uint8_t is_rx)
> +{
> + /* Do nothing, just return ok */
> + return 0;
> +}
I've just realized how this is broken.
Some Intel devices use a mapping to select hardware queues which will have
some stats. But we may have stats per queues without requiring such mapping.
I may miss something but I suggest these 3 actions:
- remove this patch
- replace checks on stats_mapping by an ethdev flag
- remove device-specific stats_mapping from ethdev
More information about the dev
mailing list