[dpdk-dev] [PATCH] mbuf: clarify comment on adding TX offload flags

Thomas Monjalon thomas.monjalon at 6wind.com
Thu Jul 9 15:59:35 CEST 2015


2015-07-09 14:22, Bruce Richardson:
> The comment for TX offload flags stated that those flags started at bit
> 55 and then were added to the right of that, leaving 8 bits reserved for
> generic mbuf (i.e. non-offload) use. This comment may not have been
> clear as 5 of the 8 flags which were reserved have now been used for TX
> offloads.

We failed to properly review some patches which are now integrated in
version 1.8. So you cannot fix it without breaking API.
It's a bit sad but your patch fixing the comment is reasonnable.

Fixes: 711ba9e23e68 ("mbuf: remove aliasing of Tx offloading flags with Rx ones")
Fixes: 1c3b7c33e977 ("mbuf: add Tx offloading flags for tunnels")


More information about the dev mailing list