[dpdk-dev] [PATCH] drivers/net/e1000/igb_ethdev.c:fix eth_igb_add_del_flex_filter

Thomas Monjalon thomas.monjalon at 6wind.com
Fri Jul 10 16:48:27 CEST 2015


We definitely need a maintainer for e1000.

2015-05-24 16:17, motomu:
> From: Motomu Utsumi <motomu at hongo.wide.ad.jp>
> 
> in add flexfiler it always write to same register address,
> so when try to adapt some filters only last one is enabled.
> I substitute value based on based on flex_filter->index for reg_off.
> 
> in del flexfilter, it delete target filter and 
> also delete first filter because of similar reason.
> I substitute value based on based on it->index for reg_off.

You forgot a Signed-off.

[...]
>  		}
> +    if (flex_filter->index < E1000_MAX_FHFT)
> +      reg_off = E1000_FHFT(flex_filter->index);
> +    else
> +      reg_off = E1000_FHFT_EXT(flex_filter->index - E1000_MAX_FHFT);

On the formatting side, it seems indent is wrong.


More information about the dev mailing list