[dpdk-dev] [PATCH v7 3/7] hash: add new functionality to store data in hash table

Thomas Monjalon thomas.monjalon at 6wind.com
Mon Jul 13 00:00:52 CEST 2015


Hi Pablo,
There is a remaining error below:

2015-07-11 01:18, Pablo de Lara:
> +int
> +rte_hash_lookup_bulk_data(const struct rte_hash *h, const void **keys,
> +                     uint32_t num_keys, uint64_t *hit_mask, void *data[])
> +{
> +       RETURN_IF_TRUE(((h == NULL) || (keys == NULL) || (num_keys == 0) ||
> +                       (num_keys > RTE_HASH_LOOKUP_BULK_MAX),
> +                       (hit_mask == NULL)), -EINVAL);
> 

lib/librte_hash/rte_cuckoo_hash.c: In function ‘rte_hash_lookup_bulk_data’:
lib/librte_hash/rte_cuckoo_hash.c:1073:41: error: left-hand operand of comma expression has no effect [-Werror=unused-value]
    (num_keys > RTE_HASH_LOOKUP_BULK_MAX),
                                         ^

The comma should be ||
Will be fixed before when applying.


More information about the dev mailing list