[dpdk-dev] [PATCH 2/2] eal: remove useless header inclusion
Thomas Monjalon
thomas.monjalon at 6wind.com
Mon Jul 27 00:18:40 CEST 2015
2015-07-23 09:15, David Marchand:
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -84,7 +84,6 @@
> #include <cmdline_parse_etheraddr.h>
> #include <cmdline_socket.h>
> #include <cmdline.h>
> -#include <rte_pci_dev_ids.h>
This one is "needed" to check bypass support.
The bypass support should be managed inside the ixgbe driver, and the
specific code in testpmd must be removed.
Waiting this cleanup, the inclusion will be moved in the #ifdef BYPASS.
Note: this ugly bypass code was already signaled few times.
If it's not reworked soon (without ifdef), it could be dropped.
More information about the dev
mailing list