[dpdk-dev] [PATCH] Make the thash library arch-independent

Thomas Monjalon thomas.monjalon at 6wind.com
Tue Jul 28 15:47:57 CEST 2015


Hi Vladimir,
Thanks for fixing.
Comments below.

2015-07-28 09:06, Vladimir Medvedkin:
> Signed-off-by: Vladimir Medvedkin <medvedkinv at gmail.com>

Please explain how it was broken and how you fixed it.
It would be interesting to know which part is __SSE3__ and __SSE__.

> +#ifdef __SSE3__
> +#include <rte_vect.h>
> +#endif /* __SSE3__ */

Comments after short ifdef block are not needed.

> +#ifndef XMM_SIZE
> +#define XMM_SIZE	16

Why is it needed?



More information about the dev mailing list