[dpdk-dev] [PATCH] Make the thash library arch-independent

[Thomas Monjalon]

2015-07-28 18:33, Vladimir Medvedkin:
> 2015-07-28 16:47 GMT+03:00 Thomas Monjalon <thomas.monjalon at 6wind.com>:
> > 2015-07-28 09:06, Vladimir Medvedkin:
> > Please explain how it was broken and how you fixed it.
> > It would be interesting to know which part is __SSE3__ and __SSE__.
> >
>  As mentioned in http://dpdk.org/ml/archives/dev/2015-July/022020.html
> compilation fails on non x86 architectures( in that case it was tile). So I
> add for optimized code, which uses SSE3 intrinsics, non optimized general
> version.

I know. I was requesting an updated commit with explanations:
	build is broken because...
	x86 version uses SSE3...
	Some code is enclosed with __SSE__, not __SSE3__ because...

What happens if it is built with SSE3 support but run on
a CPU without such support?
Please check how it is done for ACL.

> > > +#ifdef __SSE3__
> > > +#include <rte_vect.h>
> > > +#endif /* __SSE3__ */
> >
> > Comments after short ifdef block are not needed.
> >
> Should I delete it?

Yes please.

> > > +#ifndef XMM_SIZE
> > > +#define XMM_SIZE     16
> >
> > Why is it needed?
> >
>  because there is no defines for XMM_SIZE on non X86 architectures

Why XMM_SIZE is needed on non x86 arch?