[dpdk-dev] [PATCH] e1000: fix ieee1588 timestamp issue

Mcnamara, John john.mcnamara at intel.com
Thu Jul 30 11:58:52 CEST 2015


> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Thursday, July 30, 2015 9:34 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] e1000: fix ieee1588 timestamp issue
> 
> Ieee1588 reads system time to set its timestamp. On 1G NICs, for example,
> i350, system time is disabled by default. It means the ieee1588 timestamp
> will always be 0.
> This patch enables system time when ieee1588 is enabled.

Looks good.


> +#define E1000_TSAUXC_DISABLE_SYSTIME 0x80000000

Probably best to move this to the top of the file with the other timesync defines.


I wonder if this would also fix the following known issue with i210 timesyncing from the release notes:

http://dpdk.org/doc/guides/rel_notes/known_issues.html#ieee1588-support-possibly-not-working-with-an-intel-ethernet-controller-i210-nic

I don't have an i210 NIC to test but perhaps someone could verify it.

John



More information about the dev mailing list