[dpdk-dev] [PATCH v10 03/13] eal/linux: add API to set rx interrupt event monitor

Stephen Hemminger shemming at brocade.com
Tue Jun 2 18:23:00 CEST 2015


On Tue,  2 Jun 2015 14:53:16 +0800
Cunming Liang <cunming.liang at intel.com> wrote:

> +		bytes_read = read(fd, &buf, bytes_read);
> +		if (bytes_read < 0) {
> +			if (errno == EINTR || errno == EWOULDBLOCK ||
> +			    errno == EAGAIN)
> +				continue;
> +			RTE_LOG(ERR, EAL, "Error reading from file "
> +				"descriptor %d: %s\n", fd,

It is better not to split strings across multiple lines because sometimes
developers need to use tools like grep to find which file has the error
message.

Instead:
			RTE_LOG(ERR, EAL,
				"Error reading from fd %d: %s\n",
				fd, strerror(errno));


More information about the dev mailing list