[dpdk-dev] [PATCH v10 02/13] eal/linux: add rte_epoll_wait/ctl support

[Liang, Cunming]

On 6/3/2015 12:21 AM, Stephen Hemminger wrote:
> On Tue,  2 Jun 2015 14:53:15 +0800
> Cunming Liang <cunming.liang at intel.com> wrote:
>
>> The patch adds 'rte_epoll_wait' and 'rte_epoll_ctl' for async event wakeup.
>> It defines 'struct rte_epoll_event' as the event param.
>> The 'op' uses the same enum as epoll_wait/ctl does.
>> The epoll event support to carry a raw user data and to register a callback which is exectuted during wakeup.
>>
>> Signed-off-by: Cunming Liang <cunming.liang at intel.com>
>
> Minor polish comments, not blockers.
>
>
>> +static inline int
>> +eal_init_tls_epfd(void)
>> +{
>> +	int pfd = epoll_create(255);
>> +	if (pfd < 0) {
>
> Kernel style checker wants blank line after declaration here.
>
> /
>> +int
>> +rte_epoll_ctl(int epfd, int op, int fd,
>> +	      struct rte_epoll_event *event);
>> +
>> +/**
>> + * The function returns the per thread epoll instance.
>> + *
>> + * @return
>> + *   epfd the epoll instance refered to.
> Spell check: 'refered' may be misspelled - perhaps 'referred'?
>
>
>
>> + */
>> +int
>> +rte_intr_tls_epfd(void);
Thanks Stephen, will fix the typo and send the cleanup patch.