[dpdk-dev] [PATCH v2 2/3] fm10k: remove mbuf size sanity check

Chen Jing D(Mark) jing.d.chen at intel.com
Fri Jun 12 09:06:28 CEST 2015


From: "Chen Jing D(Mark)" <jing.d.chen at intel.com>

Original implementation required mbuf size should be greater than
ETHER_MAX_VLAN_FRAME_LEN, which is not necessary. If it's less
than that value, scatter function will be selected and incoming
packets greater than mbuf size will be filled into several mbufs.

Signed-off-by: Chen Jing D(Mark) <jing.d.chen at intel.com>
---
 drivers/net/fm10k/fm10k_ethdev.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index 393bcc3..714648b 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -1011,9 +1011,7 @@ handle_rxconf(struct fm10k_rx_queue *q, const struct rte_eth_rxconf *conf)
  *  2. Address is 8B aligned and buffer does not cross 4K boundary.
  *
  * As such, the driver may need to adjust the DMA address within the
- * buffer by up to 512B. The mempool element size is checked here
- * to make sure a maximally sized Ethernet frame can still be wholly
- * contained within the buffer after 512B alignment.
+ * buffer by up to 512B.
  *
  * return 1 if the element size is valid, otherwise return 0.
  */
@@ -1033,9 +1031,6 @@ mempool_element_size_valid(struct rte_mempool *mp)
 	if (min_size > mp->elt_size)
 		return 0;
 
-	if (min_size < ETHER_MAX_VLAN_FRAME_LEN)
-		return 0;
-
 	/* size is valid */
 	return 1;
 }
-- 
1.7.7.6



More information about the dev mailing list