[dpdk-dev] [PATCH] pmd_ring: return new port id on ethdev creation

Thomas Monjalon thomas.monjalon at 6wind.com
Mon Jun 22 17:33:15 CEST 2015


> The rte_eth_from_rings API allowed the creation of an ethdev port at
> runtime using rte_rings as the underlying storage. However, the return
> value from this function was either 0 or -1, and these values were never
> actually documented in the API documentation. Unfortunately, the programmers
> guide doc examples for this API implied that the return value from this
> function was the port id of the newly created ethdev.
> 
> Since this latter behaviour is more useful - and already implied by the
> documentation, this patch changes the return 0 to "return
> data->port_id". It also adds in doxygen comments for the function so it
> can be correctly documented in the API reference.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>

Applied, thanks


More information about the dev mailing list