[dpdk-dev] [PATCH v2] cfgfile: fix unitialised buffer
Bruce Richardson
bruce.richardson at intel.com
Mon Jun 29 16:33:52 CEST 2015
On Mon, Jun 29, 2015 at 04:20:25PM +0200, Daniel Mrzyglod wrote:
> Nature of the problem was not initialised buffer[256], there were probability
> that operation system will provide previously used memory and on special condition
> there were probability that string operations will work on random data that
> could provide unexpected program behaviour.
>
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod at intel.com>
> ---
> lib/librte_cfgfile/rte_cfgfile.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c
> index b81c273..9c85e9f 100644
> --- a/lib/librte_cfgfile/rte_cfgfile.c
> +++ b/lib/librte_cfgfile/rte_cfgfile.c
> @@ -96,7 +96,10 @@ rte_cfgfile_load(const char *filename, int flags)
> int lineno = 0;
> struct rte_cfgfile *cfg = NULL;
>
> + memset(buffer, '\0', sizeof(buffer));
> +
> FILE *f = fopen(filename, "r");
> +
> if (f == NULL)
> return NULL;
>
> --
> 2.1.0
>
How about just adding "= {0}" to the end of the definition of buffer?
/Bruce
More information about the dev
mailing list