[dpdk-dev] [PATCH v3 1/8] eal: Add pci_uio_alloc_uio_resource()

[Tetsuya Mukawa]

On 2015/06/29 22:24, Iremonger, Bernard wrote:
>
>> -----Original Message-----
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Monday, June 29, 2015 3:57 AM
>> To: dev at dpdk.org
>> Cc: Iremonger, Bernard; david.marchand at 6wind.com; Tetsuya.Mukawa
>> Subject: [PATCH v3 1/8] eal: Add pci_uio_alloc_uio_resource()
>>
>> From: "Tetsuya.Mukawa" <mukawa at igel.co.jp>
>>
>> This patch adds a new function called pci_uio_alloc_uio_resource().
>> The function hides how to prepare uio resource in linuxapp and bsdapp.
>> With the function, pci_uio_map_resource() will be more abstracted.
>>
>> Signed-off-by: Tetsuya Mukawa <mukawa at igel.co.jp>
> Hi Tetsuya,
>
> There are two comments inline below.
>
>> ---
>>  lib/librte_eal/bsdapp/eal/eal_pci.c       | 70 +++++++++++++++++++---------
>>  lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 77 ++++++++++++++++++++++---
>> ------
>>  2 files changed, 104 insertions(+), 43 deletions(-)
>>
>> diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c
>> b/lib/librte_eal/bsdapp/eal/eal_pci.c
>> index 06c564f..2d9f3a5 100644
>> --- a/lib/librte_eal/bsdapp/eal/eal_pci.c
>> +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
>> @@ -189,28 +189,17 @@ pci_uio_map_secondary(struct rte_pci_device
>> *dev)
>>  	return 1;
>>  }
>>
>> -/* map the PCI resource of a PCI device in virtual memory */  static int -
>> pci_uio_map_resource(struct rte_pci_device *dev)
>> +pci_uio_alloc_uio_resource(struct rte_pci_device *dev,
>> +		struct mapped_pci_resource **uio_res)
> The name of this function is a bit longwinded,  pci_uio_alloc_resource() might be better.

Hi Bernard,

Thanks for comments.
Sure I will fix it.

>>
>> -/* map the PCI resource of a PCI device in virtual memory */ -int -
>> pci_uio_map_resource(struct rte_pci_device *dev)
>> +static int
>> +pci_uio_alloc_uio_resource(struct rte_pci_device *dev,
>> +		struct mapped_pci_resource **uio_res)
> The name of this function is a bit longwinded,  pci_uio_alloc_resource() might be better.

Also, I will fix above.

Regards,
Tetsuya