[dpdk-dev] [PATCH] eal: prevent dereferencing NULL pointer in rte_eal_devargs_add()
Pawel Wodkowski
pawelx.wodkowski at intel.com
Mon Mar 2 12:09:22 CET 2015
On failure devargs->args should not be accesed if devargs is NULL.
Signed-off-by: Pawel Wodkowski <pawelx.wodkowski at intel.com>
---
lib/librte_eal/common/eal_common_devargs.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c
index 9b110f7..615945e 100644
--- a/lib/librte_eal/common/eal_common_devargs.c
+++ b/lib/librte_eal/common/eal_common_devargs.c
@@ -124,12 +124,13 @@ rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str)
return 0;
fail:
- if (devargs->args)
- free(devargs->args);
if (buf)
free(buf);
- if (devargs)
+ if (devargs) {
+ free(devargs->args);
free(devargs);
+ }
+
return -1;
}
--
1.9.1
More information about the dev
mailing list