[dpdk-dev] [PATCH v7] af_packet: Fix some klocwork errors

Thomas Monjalon thomas.monjalon at 6wind.com
Tue Mar 17 22:34:44 CET 2015


> > > > Fix possible memory leak issue: free kvlist before return;
> > > > Fix possible resource lost issue: close qssockfd before return;
> > > >
> > > > Signed-off-by: Changchun Ouyang <changchun.ouyang at intel.com>
> > > > ---
> > > > Change in v7:
> > > >   - Remove unnecessary '!= NULL' check before freeing it; 
> > > >
> > > > Change in v6:
> > > >   - Refine exit point;
> > > >  
> > > > Change in v5:
> > > >   - Initialize qsockfd with -1;
> > > >  
> > > > Change in v4:
> > > >   - Check sockfd in internals->rx_queue against 0;
> > > >  
> > > > Change in v3:
> > > >   - Also close sockets for all queues;
> > > >  
> > > > Change in v2:
> > > >   - Make the error exit point a common path.
> > > 
> > > Acked-by: Michael Qiu <michael.qiu at intel.com>
> > Acked-by: Neil Horman <nhorman at tuxdriver.com>
> 
> Acked-by: John W. Linville <linville at tuxdriver.com>

Applied, thanks


More information about the dev mailing list