[dpdk-dev] [PATCH v2 15/15] eal: Enable Port Hotplug as default in Linux and BSD

[Iremonger, Bernard]

> -----Original Message-----
> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
> Sent: Tuesday, March 17, 2015 8:08 AM
> To: Iremonger, Bernard; dev at dpdk.org
> Cc: Richardson, Bruce
> Subject: Re: [PATCH v2 15/15] eal: Enable Port Hotplug as default in Linux and BSD
> 
> On 2015/03/14 0:47, Iremonger, Bernard wrote:
> >
> >> -----Original Message-----
> >> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
> >> Sent: Thursday, March 12, 2015 10:18 AM
> >> To: dev at dpdk.org
> >> Cc: Iremonger, Bernard; Richardson, Bruce; Tetsuya Mukawa
> >> Subject: [PATCH v2 15/15] eal: Enable Port Hotplug as default in
> >> Linux and BSD
> >>
> >> This patch removes CONFIG_RTE_LIBRTE_EAL_HOTPLUG option, and enables
> >> it as default in both Linux and BSD.
> > Hi Tetsuya,
> >
> > This patch should probably be split with the config changes as the first patch of this patch set.
> > The #ifdef RTE_LIBRTE_EAL_HOTPLUG changes should be no longer necessary as they will have
> been taken care of in the earlier patches (v2-11, v2-12, v2-13).
> > Maybe the  /lib/librte_eal/bsdapp/eal/rte_eal_version.map changes could be moved to one of the
> earlier bsd patches?
> 
> Hi Bernard,
> 
> Could I make it sure your suggestion?
> Did you mean that hotplug support for linuxapp and bsdapp should be enabled at first of consolidation
> patches?
> 
> It seems I can remove "#ifdef RTE_LIBRTE_EAL_HOTPLUG" together with below patches.
>  - v2-11
>  - v2-12
>  - v2-13
> (Probably this will clean up the last patch a bit.)
> 
> But I cannot enable hotplug support at the first of consolidation patches, because bsdapp doesn't
> have some hotplug implementation at the first.
> (Actually, functions related with detach() are only exist in linuxapp at the first.) All related functions
> are moved to common while patch set, then bsdapp can support hotplug.
> 
> I will clean up the last patch as much as possible, then submit again.
> Is it okay for this patch?
> 
> Regards,
> Tetsuya
> 
Hi Tetsuya,

Ok, clean up as much as possible and then submit again as v3.

Regards,

Bernard.