[dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'

Thomas Monjalon thomas.monjalon at 6wind.com
Fri Mar 27 14:15:25 CET 2015


> > > > Due to increased `struct file's reference counter subsequent call
> > > > to `filp_close' does not free the `struct file'. Prepend `fput' call
> > > > to decrease the reference counter.
> > > >
> > > > Signed-off-by: Pavel Boldin <pboldin at mirantis.com>
> > >
> > > Acked-by Huawei Xie <huawei.xie at intel.com>
> >
> > Applied, thanks
> 
> What should I do with the refactoring patch in your opinion?
> 
> Should I split it in parts to ease review?

I didn't review it so I have no good advice.
But in general, it's better to split patches in logic units if it makes sense.
Note that we are closing 2.0. Refactoring patches are deffered to 2.1.


More information about the dev mailing list