[dpdk-dev] [PATCH v4 1/5] vhost: eventfd_link: moving ioctl to a function

Pavel Boldin pboldin at mirantis.com
Thu May 7 15:16:34 CEST 2015


On Thu, May 7, 2015 at 10:57 AM, Xie, Huawei <huawei.xie at intel.com> wrote:

> On 4/3/2015 1:02 AM, Pavel Boldin wrote:
> > Move ioctl `EVENTFD_COPY' handler code to an inline function.
> Pavel:
> There is no necessity to inline this function.
>
Xie, there is even no necessity to split this in a five piece patchseries.
I did that solely for the purpose of clean reading.

There is no necessity to inline any single-used functions as long the
compiler is decent. But I prefer to instruct compiler to do this explictly
so there is no call/ret path in the generated code.

Pavel



> /huawei
>


More information about the dev mailing list