[dpdk-dev] [PATCH v2 1/2] i40e/base: compile fix on ICC 13.0.0
Bruce Richardson
bruce.richardson at intel.com
Mon May 18 17:13:46 CEST 2015
On Mon, May 18, 2015 at 04:11:06PM +0100, Bruce Richardson wrote:
> On Mon, May 18, 2015 at 11:03:28PM +0800, Helin Zhang wrote:
> > Below compile error can be found on ICC 13.0.0, which is a warning
> > treated as error. Forcedly disabling the warning can fix it.
> >
> > Error log:
> > lib/librte_pmd_i40e/i40e/i40e_nvm.c(1022): error #188: enumerated
> > type mixed with another type
> > hw->aq.asq_last_status = old_asq_status;
> > ^
> >
> > Signed-off-by: Helin Zhang <helin.zhang at intel.com>
>
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>
>
Fix works, but you probably should reword the title to start with "fix".
For future reference, it would also be nice to reference the commit that broke things.
> > ---
> > lib/librte_pmd_i40e/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_pmd_i40e/Makefile b/lib/librte_pmd_i40e/Makefile
> > index 22f0716..911e4f5 100644
> > --- a/lib/librte_pmd_i40e/Makefile
> > +++ b/lib/librte_pmd_i40e/Makefile
> > @@ -48,7 +48,7 @@ LIBABIVER := 1
> > # to disable warnings
> > #
> > ifeq ($(CC), icc)
> > -CFLAGS_BASE_DRIVER = -wd593
> > +CFLAGS_BASE_DRIVER = -wd593 -wd188
> > else ifeq ($(CC), clang)
> > CFLAGS_BASE_DRIVER += -Wno-sign-compare
> > CFLAGS_BASE_DRIVER += -Wno-unused-value
> > --
> > 1.8.1.4
> >
More information about the dev
mailing list