[dpdk-dev] default unicast mac address - was: add multicast address filtering

Stephen Hemminger stephen at networkplumber.org
Fri May 29 17:18:57 CEST 2015


On Fri, 29 May 2015 15:12:28 +0200
Thomas Monjalon <thomas.monjalon at 6wind.com> wrote:

> Hi Stephen,
> 
> Looking at mac address management, you and Changchun added an entry in
> driver ops to be able to change the default mac address with virtio:
> 	http://dpdk.org/browse/dpdk/commit/?id=5186fb1f37fe986
> Other ops functions (mac_addr_add/remove) manage the secondary unicast
> mac addresses and have a wrapper function in the API:
> 	http://dpdk.org/doc/api/rte__ethdev_8h.html#aa2b81750086f5f9e55cf65e5cf9f2c58
> 
> It seems now that the review of the above patch was too weak and I'd like
> these issues to be fixed:
> 	- mac_addr_set must be wrapped by rte_eth_dev_mac_addr_set()
> 	- eth_mac_addr_set_t must be fixed to explicitly state that it
> replaces the default address

Sure, also some other drivers need mac_addr_set hook.


More information about the dev mailing list