[dpdk-dev] [PATCH v7 00/28] remove pci driver from vdevs

Qiu, Michael michael.qiu at intel.com
Mon Nov 2 06:28:50 CET 2015


Hi, Bernard

Could we merge some patch together? I see lots of patches are simple and
doing the same thing but in different NIC, merge them almost have no
affect of review, what's more it will make reviewers more comfortable
with less and simple patches.

Then we could have a clean patch set with almost 5 patches, not totally 28.

librte_eal: add RTE_KDRV_NONE for vdevs
librte_ether: add fields from rte_pci_driver to rte_eth_dev_data
drivers: copy pci device info to eth_dev data
librte_ether: remove branches on pci_dev
drivers: remove pci device

At least, we could merge serial patches "xxxx:copy pci device info to
eth_dev data" to "drivers: copy pci device info to eth_dev data" in my mind.

Just an advise, but better to have.

Thanks,
Michael
On 2015/10/30 23:09, Bernard Iremonger wrote:
> There is a dummy pci driver in the vdev PMD's at present.
> This patch set removes the pci driver from the vdev PMD's.
> Changes have been made to librte_ether to handle vdevs and pdevs in the same way.
>
> The following vdev PMD's have had the pci driver removed:
>
> null
> ring
> bonding
> pcap
> af_packet
> xenvirt
> mpipe
>
> All the pdev PMD's have been modified to copy the pci device info into eth_dev data.
>
> Changes in v7:
> rebase to latest code.
>
> Changes in v6:
> Initialise data->drv_name with the PMD driver name in the vdevs.
> Remove two more branches on pci_dev from the bonding vdev.
>
> Changes in v5:
> rebase to latest code.
> refactor patches to avoid potential problems with git bisect.
>
> Changes in v4:
> rebase to latest code.
> add doxygen comments to rte_ethdev.h
> update release notes in patch 0002.
>
> Changes in v3:
> rebase to latest code.
> restructure patches 0002 and 0003 to fix compile issue in patch 0002.
>
> Changes in V2:
> rebase to latest code.
> fix compile error in rte_ethdev.c when debug disabled.
> remove Intel copyright from bnx2x, cxgbe, enic, mlx4, mpipe and null PMD's.
>
> Bernard Iremonger (28):
>   librte_eal: add RTE_KDRV_NONE for vdevs
>   librte_ether: add fields from rte_pci_driver to rte_eth_dev_data
>   librte_ether: add function rte_eth_copy_dev_info
>   ixgbe: copy pci device info to eth_dev data
>   e1000: copy pci device info to eth_dev data
>   i40e: copy pci device info to eth_dev data
>   fm10k: copy pci device info to eth_dev data
>   bnx2x: copy pci device info to eth_dev data
>   cxgbe: copy pci device info to eth_dev data
>   enic: copy pci device info to eth_dev data
>   mlx4: copy pci device info to eth_dev data
>   virtio: copy pci device info to eth_dev data
>   vmxnet3: copy pci device info to eth_dev data
>   null: copy device info to eth_dev data
>   ring: copy device info to eth_dev data
>   pcap: copy device info to eth_dev data
>   af_packet: copy device info to eth_dev data
>   xenvirt: copy device info to eth_dev data
>   mpipe: copy device info to eth_dev data
>   bonding: copy device info to eth_dev data
>   librte_ether: remove branches on pci_dev
>   null: remove pci device
>   ring: remove pci device
>   pcap: remove pci device
>   af_packet: remove pci device
>   xenvirt: remove pci device
>   mpipe: remove pci device
>   bonding: remove pci device
>
>  doc/guides/rel_notes/release_2_2.rst       |  4 ++
>  drivers/net/af_packet/rte_eth_af_packet.c  | 20 ++++------
>  drivers/net/bnx2x/bnx2x_ethdev.c           |  3 ++
>  drivers/net/bonding/rte_eth_bond_8023ad.c  |  4 +-
>  drivers/net/bonding/rte_eth_bond_alb.c     |  2 +-
>  drivers/net/bonding/rte_eth_bond_api.c     | 60 +++++++++---------------------
>  drivers/net/bonding/rte_eth_bond_pmd.c     | 18 ++++-----
>  drivers/net/bonding/rte_eth_bond_private.h |  2 +-
>  drivers/net/cxgbe/cxgbe_ethdev.c           |  3 ++
>  drivers/net/e1000/em_ethdev.c              |  3 ++
>  drivers/net/e1000/igb_ethdev.c             |  5 +++
>  drivers/net/enic/enic_ethdev.c             |  1 +
>  drivers/net/fm10k/fm10k_ethdev.c           |  2 +
>  drivers/net/i40e/i40e_ethdev.c             |  3 ++
>  drivers/net/i40e/i40e_ethdev_vf.c          |  2 +
>  drivers/net/ixgbe/ixgbe_ethdev.c           |  4 ++
>  drivers/net/mlx4/mlx4.c                    |  3 ++
>  drivers/net/mpipe/mpipe_tilegx.c           | 10 +++--
>  drivers/net/null/rte_eth_null.c            | 29 ++++-----------
>  drivers/net/pcap/rte_eth_pcap.c            | 31 +++++----------
>  drivers/net/ring/rte_eth_ring.c            | 37 ++++--------------
>  drivers/net/virtio/virtio_ethdev.c         |  3 ++
>  drivers/net/vmxnet3/vmxnet3_ethdev.c       |  2 +
>  drivers/net/xenvirt/rte_eth_xenvirt.c      | 18 ++++-----
>  lib/librte_eal/common/include/rte_pci.h    |  3 +-
>  lib/librte_ether/rte_ethdev.c              | 54 +++++++++++++++------------
>  lib/librte_ether/rte_ethdev.h              | 29 +++++++++++++++
>  lib/librte_ether/rte_ether_version.map     |  7 ++++
>  28 files changed, 185 insertions(+), 177 deletions(-)
>



More information about the dev mailing list