[dpdk-dev] [PATCH] reserve 'make install' for future use

[Bruce Richardson]

So, any thoughts or comments on this? There has been lots of discussion in this
general area but nothing yet going into the release to try and improve the situation.

Are we just going to kick the problem down the road to the 2.3 release?

/Bruce


On Fri, Nov 06, 2015 at 10:24:13AM +0000, Bruce Richardson wrote:
> There has been some discussion on the list about various ways to get DPDK more
> standardised in how it compiles and how it can be installed into a system as
> a set of binaries.
> 
> One of the issues we face in that is that the 'make install' command is used in
> DPDK to compile a copy of the SDK but not to place the resultant binaries in the
> filesystem like other packages do. In order to allow us to have the option to
> use 'make install' in its common meaning in a future release we need to replace
> it in our packages, and allow some time for the change to a new command to bed-in.
> 
> This patchset therefore proposed to change "make install" to "make sdk" [and
> "make uninstall" to "make clean-sdk"]. Using the old commands now prints out
> an error message informing the user to use the new versions.
> 
> These new commands are ones that made sense to me - I'm happy enough to change
> them for something else people feel is more appropriate. The key point here is
> to move away from using "make install".
> 
> I would ask that if general agreement on this can be reached that such a change
> be considered for 2.2, even though it is late in the day, as "freeing up" the
> make install command will potentially take multiple releases as not everyone is
> on the latest version, and so waiting till 2.3 to make a change will push out
> any future re-use of a "make install" command by 4 months.
> 
> Regards,
> /Bruce
> 
> Bruce Richardson (1):
>   mk: rename 'make install' to 'make sdk'
> 
>  doc/guides/freebsd_gsg/build_dpdk.rst            | 16 ++---
>  doc/guides/linux_gsg/build_dpdk.rst              | 22 +++---
>  doc/guides/nics/intel_vf.rst                     |  2 +-
>  doc/guides/prog_guide/dev_kit_root_make_help.rst | 18 ++---
>  doc/guides/sample_app_ug/tep_termination.rst     |  3 +-
>  doc/guides/sample_app_ug/vhost.rst               |  3 +-
>  doc/guides/testpmd_app_ug/build_app.rst          |  2 +-
>  doc/guides/xen/pkt_switch.rst                    |  2 +-
>  mk/rte.sdk.mk                                    | 88 ++++++++++++++++++++++++
>  mk/rte.sdkinstall.mk                             | 87 -----------------------
>  mk/rte.sdkroot.mk                                | 13 +++-
>  scripts/gen-build-mk.sh                          |  2 +-
>  12 files changed, 133 insertions(+), 125 deletions(-)
>  create mode 100644 mk/rte.sdk.mk
>  delete mode 100644 mk/rte.sdkinstall.mk
> 
> -- 
> 2.5.0
>