[dpdk-dev] [PATCH 1/6] librte_log: add function to retrieve log_level

Thomas Monjalon thomas.monjalon at 6wind.com
Fri Nov 13 12:49:36 CET 2015


2015-11-13 11:40, Bruce Richardson:
> On Fri, Nov 13, 2015 at 06:47:33AM +0000, Matthew Hall wrote:
> > --- a/lib/librte_eal/common/include/rte_log.h
> > +++ b/lib/librte_eal/common/include/rte_log.h
> > @@ -131,6 +131,7 @@ void rte_set_log_level(uint32_t level);
> >  
> >  /**
> >   * Get the global log level.
> > + *
> >   */
> >  uint32_t rte_get_log_level(void);
> >  
> I don't think this patch is necessary, as all it adds is a single extra line to
> a comment.

I'm sad for you Bruce: you only see an empty line where you could catch
the beauty of the star ;)

Matthew, obviously you failed your send.
As a general comment, please group patches by logic meaning and
check them before sending ;)


More information about the dev mailing list