[dpdk-dev] [PATCH v6 3/5] ethdev: redesign link speed config API

Marc Sune marcdevel at gmail.com
Wed Nov 18 23:59:56 CET 2015


Hi Thomas,

2015-11-01 23:16 GMT+01:00 Thomas Monjalon <thomas.monjalon at 6wind.com>:

> 2015-10-25 22:59, Marc Sune:
> > This patch redesigns the API to set the link speed/s configure
> > for an ethernet port. Specifically:
> >
> > - it allows to define a set of advertised speeds for
> >   auto-negociation.
> > - it allows to disable link auto-negociation (single fixed speed).
> > - default: auto-negociate all supported speeds.
> >
> > Other changes:
> >
> > * Added utility MACROs ETH_SPEED_NUM_XXX with the numeric
> >   values of all supported link speeds, in Mbps.
> > * Converted link_speed to uint32_t to accomodate 100G speeds
> >   (bug).
> > * Added autoneg flag in struct rte_eth_link to indicate if
> >   link speed was a result of auto-negociation or was fixed
> >   by configuration.
> > * Added utility function to convert numeric speeds to bitmap
> >   fields.
>
> Having it split in several commits may help to understand the changes.
>

Apologies for the late response... crazy days.

At least first and last point in the enumeration do not make sense alone. I
can split the link_speed bug for 100G in another patch if you consider is
necessary for the series to be merged in.


> And it must be explained in the release notes in the "API changes".
>

Patch 4/5 in the series attempts to cover this:

http://dpdk.org/dev/patchwork/patch/7996/

Isn't it enough?

Marc


More information about the dev mailing list