[dpdk-dev] [PATCH] Revert "eal: set name to threads"

[Ferruh Yigit]

On Thu, Nov 19, 2015 at 01:32:44PM +0100, Thomas Monjalon wrote:
> 2015-11-19 13:49, Panu Matilainen:
> > On 11/19/2015 01:22 PM, Ferruh Yigit wrote:
> > > This reverts commit 67b6d3039e9edbc4624c878c6930be5e126e8b58.
> > >
> > > Reverted patch uses pthread_setname_np() function, this function added
> > > into glibc in version 2.12 and cause a compile error in older glibc
> > > versions:
> > > error: implicit declaration of function "pthread_setname_np"
> > >
> > > Main purpose of reverted patch is to name threads, without
> > > pthread_setname_np() function, patch does not mean much, so reverting
> > > patch for sake of compatibility with older glibc versions.
> > 
> > Debuggability is important too. Rather than revert, why not wrap it in 
> > rte_thread_setname() or such and just make it a no-op with glibc 
> > versions where pthread_setname_np() is not available?
> 
> +1

Which means adding compile time glibc version check which I was trying to avoid,
I believe we should not add glibc version dependencies unless feature is really required,
but sure I can implement that way, will send v2.

Thanks,
ferruh