[dpdk-dev] [PATCH v5 0/2] ethdev: debug code cleanup
Bruce Richardson
bruce.richardson at intel.com
Tue Nov 24 18:37:55 CET 2015
This patchset performs two cleanups:
1. Four functions in ethdev.c which were enabled for debug only have been
merged into their inlined header-file counterparts. This change required that
a number of macros be renamed and moved to the header file too. The macro changes
are in patches 1 & 2, and the elimination of the separate debug fns are in patch 3.
2. Checks for valid function pointers are added to the API calls for reading
the descriptor ring count, and checking for a valid descriptor. This is because
these functions are not implemented by most drivers, and so it's far safer to
have the check.
NOTE: This patchset now depends upon the cryptodev patchset
---
V5 Changes:
* Remove the 4 debug functions from the map file and, as a result of this, move all
previous functions to the new 2_2 version, sorting them alphabetically.
* Update release notes to cover ABI change
* Update release notes to cover API change for the rx_count() function
V4 Changes:
* Originally this was a 4-patch set, but patches 1 and 2 duplicated changes being
made in the patchset to add crypto device support. Therefore this set has
been reduced to two patches to sit on top of that set.
* As suggested on-list, when adding checks for the function pointers being
valid we can also add in the similarly lightweight checks for the port id
being valid.
V3 Changes:
* Rebased to latest DPDK codebase
* Fixed checkpatch issues in patches 2 and 3.
V2 Changes:
* Rebased to latest DPDK codebase
* Changed type from uint32_t to int for the count function, on the basis of
feedback received.
Bruce Richardson (2):
ethdev: remove duplicated debug functions
ethdev: add sanity checks to functions
doc/guides/rel_notes/release_2_2.rst | 7 ++++
lib/librte_ether/rte_ethdev.c | 64 ---------------------------------
lib/librte_ether/rte_ethdev.h | 62 ++++++++++++++++----------------
lib/librte_ether/rte_ether_version.map | 66 +++++++++++++---------------------
4 files changed, 61 insertions(+), 138 deletions(-)
--
2.5.0
More information about the dev
mailing list