[dpdk-dev] [PATCH] distributor: fix compilation on icc 2015

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Fri Nov 27 11:39:00 CET 2015


Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, November 27, 2015 10:10 AM
> To: De Lara Guarch, Pablo
> Cc: dev at dpdk.org; Qiu, Michael
> Subject: Re: [dpdk-dev] [PATCH] distributor: fix compilation on icc 2015
> 
> 2015-11-27 09:49, Pablo de Lara:
> > Fix following error on icc 2015:
> >
> >   CC main.o
> > /tmp/dpdk-tmp3/examples/distributor/main.c(338): error #167:
> >   argument of type "struct rte_mbuf *" is incompatible with
> >   parameter of type "const char *"
> >         _mm_prefetch(bufs[0], 0);
> >
> > Fixes: 07db4a97 ("examples/distributor: new sample app")
> >
> > Reported-by: Yongjie Gu <yongjiex.gu at intel.com>
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
> 
> Hi Pablo,
> 
> It is the same patch as the first one of Michael which fails with clang:
> 	http://dpdk.org/ml/archives/dev/2015-November/028929.html
> He has sent a second one without "const".

Oh yes, didn't see it, sorry about that.
Actually, it is strange that clang complains with const,
but not in virtio_rxtx_simple.c, where we use (const void *) in _mm_prefetch.
So, NACK to this patch and I will ack the other one.


More information about the dev mailing list