[dpdk-dev] [PATCHv5 1/8] ethdev: add new API to retrieve RX/TX queue information

Ananyev, Konstantin konstantin.ananyev at intel.com
Wed Oct 14 20:44:38 CEST 2015



> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Wednesday, October 14, 2015 5:09 PM
> To: Ananyev, Konstantin
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCHv5 1/8] ethdev: add new API to retrieve RX/TX queue information
> 
> On Thu,  1 Oct 2015 20:54:46 +0100
> Konstantin Ananyev <konstantin.ananyev at intel.com> wrote:
> 
> > +	if (nb_rx_desc > dev_info.rx_desc_lim.nb_max ||
> > +			nb_rx_desc < dev_info.rx_desc_lim.nb_min ||
> > +			nb_rx_desc % dev_info.rx_desc_lim.nb_align != 0) {
> > +
> 
> Preferred indentation style is to line up the conditional.
> 	if (nb_rx_desc > dev_info.rx_desc_lim.nb_max ||
> 	    nb_rx_desc < dev_info.rx_desc_lim.nb_min ||
> 	    nb_rx_desc % dev_info.rx_desc_lim.nb_align != 0) {


As I remember within DPDK we use an extra tab as preferred indentation style for several years.
Why it suddenly changed now?
Konstantin




More information about the dev mailing list