[dpdk-dev] [PATCH v6 06/13] virtio: read virtio_net_config correctly

Thomas Monjalon thomas.monjalon at 6wind.com
Tue Oct 20 09:07:49 CEST 2015


2015-10-09 13:46, Yuanhan Liu:
> From: Changchun Ouyang <changchun.ouyang at intel.com>
> 
> The old code adjusts the config bytes we want to read depending on
> what kind of features we have, but we later cast the entire buf we
> read with "struct virtio_net_config", which is obviously wrong.

When describing a bug, it is important to explain what is the consequence,
i.e. which use case is failing. If it is only to prepare the new feature,
it is better to clearly state that the bug had no impact until now.

And as usual, the "fix" word in the title and the "Fixes" tag are required.


More information about the dev mailing list