[dpdk-dev] [PATCH v5 1/4] vhost: eventfd_link: refactoring EVENTFD_COPY handler

Xie, Huawei huawei.xie at intel.com
Tue Oct 20 11:06:54 CEST 2015


On 8/29/2015 2:51 AM, Pavel Boldin wrote:
> * Move ioctl `EVENTFD_COPY' code to a separate function
> * Remove extra #includes
> * Introduce function fget_from_files
> * Fix ioctl return values
>
> Signed-off-by: Pavel Boldin <pboldin at mirantis.com>
Basically OK with this patch since we have reviewed before.
Could you split the patch, one change each patch? Thomas will require
you to do this too. :). I see you have also changed when to call
put_files_struct. It is better put it in a separate patch with the reason.
Another thing is code style. Run checkpatch.pl against your patch. There
are some issues.


More information about the dev mailing list