[dpdk-dev] [PATCH v3 02/20] librte_ether: add fields from rte_pci_driver to rte_eth_dev_data

Iremonger, Bernard bernard.iremonger at intel.com
Tue Oct 20 13:18:19 CEST 2015


Hi  Michael,

<snip>

> > @@ -1795,8 +1790,7 @@ rte_eth_dev_info_get(uint8_t port_id, struct
> rte_eth_dev_info *dev_info)
> >  	FUNC_PTR_OR_RET(*dev->dev_ops->dev_infos_get);
> >  	(*dev->dev_ops->dev_infos_get)(dev, dev_info);
> >  	dev_info->pci_dev = dev->pci_dev;
> 
> Here also pci_dev, I think after you remove pci_dev from vdevs, and this
> field could be remove I think, as I don't see any use of this field in dev_info, it
> should be more general and not only PCI.
> 
> Thanks,
> Michael

<snip>

At present there are PCI  pdevs  and vdevs without PCI.
The field is still relevant  for the pdevs, for the vdevs it will be NULL.
I would prefer to retain this field.
This patch set is not intended to handle other bus types.

Regards,

Bernard.






More information about the dev mailing list