[dpdk-dev] [PATCH 1/6] cryptodev: Initial DPDK Crypto APIs and device framework release

Declan Doherty declan.doherty at intel.com
Wed Oct 21 13:16:20 CEST 2015


On 21/10/15 10:24, Thomas Monjalon wrote:
> Hi Declan,
>
> 2015-10-03 00:01, Declan Doherty:
>> Co-authored-by: Des O Dea <des.j.o.dea at intel.com>
>> Co-authored-by: John Griffin <john.griffin at intel.com>
>> Co-authored-by: Fiona Trahe <fiona.trahe at intel.com>
>
> Common practice is to use Signed-off-by below for co-authors.

Cool, I didn't know that, I will change in the V2.

>
>> This patch contains the initial proposed APIs and device framework for
>> integrating crypto packet processing into DPDK.
>>
>> features include:
>>   - Crypto device configuration / management APIs
>>   - Definitions of supported cipher algorithms and operations.
>>   - Definitions of supported hash/authentication algorithms and
>>     operations.
>>   - Crypto session management APIs
>>   - Crypto operation data structures and APIs allocation of crypto
>>     operation structure used to specify the crypto operations to
>>     be performed  on a particular mbuf.
>>   - Extension of mbuf to contain crypto operation data pointer and
>>     extra flags.
>>   - Burst enqueue / dequeue APIs for processing of crypto operations.
>
> It would be easier to review if features were split in separate patches.
> You don't need to have a fine grain but maybe 1 patch for basic management
> then 1 for the session management, 1 for the algos and another 1 for the stats.

I'll take a look and see how feasible it would be to split the patches 
that way.

>
> Other comment: you've added some API which are not implemented (hotplug, restore).
> Why not declare them later when they will be implemented?
>

I'll remove these

> The QuickAssist doc is not needed if the code is not submitted.
>

There is a QuickAssist PMD included in the patch set, see patch 2/6

> Volunteer for a sub-tree?
> Thanks.
>



More information about the dev mailing list