[dpdk-dev] [PATCH v2 2/2] examples: new example: l2fwd-ethtool

Thomas Monjalon thomas.monjalon at 6wind.com
Wed Oct 21 18:36:12 CEST 2015


2015-07-23 11:00, Liang-Min Larry Wang:
>  examples/Makefile                                |    1 +
>  examples/l2fwd-ethtool/Makefile                  |   48 +
>  examples/l2fwd-ethtool/l2fwd-app/Makefile        |   58 ++
>  examples/l2fwd-ethtool/l2fwd-app/main.c          | 1025 ++++++++++++++++++++++
>  examples/l2fwd-ethtool/l2fwd-app/netdev_api.h    |  770 ++++++++++++++++
>  examples/l2fwd-ethtool/l2fwd-app/shared_fifo.h   |  159 ++++
>  examples/l2fwd-ethtool/lib/Makefile              |   57 ++
>  examples/l2fwd-ethtool/lib/rte_ethtool.c         |  336 +++++++
>  examples/l2fwd-ethtool/lib/rte_ethtool.h         |  385 ++++++++
>  examples/l2fwd-ethtool/nic-control/Makefile      |   55 ++
>  examples/l2fwd-ethtool/nic-control/nic_control.c |  614 +++++++++++++
>  11 files changed, 3508 insertions(+)

This patch is huge.
Please split a bit.

> --- a/examples/Makefile
> +++ b/examples/Makefile
> @@ -53,6 +53,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_KNI) += kni
>  DIRS-y += l2fwd
>  DIRS-$(CONFIG_RTE_LIBRTE_IVSHMEM) += l2fwd-ivshmem
>  DIRS-$(CONFIG_RTE_LIBRTE_JOBSTATS) += l2fwd-jobstats
> +DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += l2fwd-ethtool
>  DIRS-y += l3fwd

Please keep the alphabetical order.

I do not plan to review it more.
If nobody complains, it means it's accepted.


More information about the dev mailing list