[dpdk-dev] [PATCH v4] ixgbe: Drop flow control frames from VFs

Vladislav Zolotarov vladz at cloudius-systems.com
Fri Oct 23 08:24:11 CEST 2015


On Oct 23, 2015 9:02 AM, "Zhang, Helin" <helin.zhang at intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Lu, Wenzhuo
> > Sent: Friday, October 23, 2015 1:52 PM
> > To: dev at dpdk.org
> > Cc: Zhang, Helin; Lu, Wenzhuo
> > Subject: [PATCH v4] ixgbe: Drop flow control frames from VFs
> >
> > This patch will drop flow control frames from being transmitted from
VSIs.
> > With this patch in place a malicious VF cannot send flow control or PFC
packets
> > out on the wire.

The whole idea of this (and similar i40e patches sent before) is really
confusing.
If u want to disable FC feature for VFs then go and disable the feature.
Why keep (not malicious) user think that he/she has enabled the feature
while u silently block it?


> >
> > V2:
> > Reword the comments.
> >
> > V3:
> > Move the check of set_ethertype_anti_spoofing to the top of the
function, to
> > avoid occupying an ethertype_filter entity without using it.
> >
> > V4:
> > Remove the useless braces and return.
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu at intel.com>
> Acked-by: Helin Zhang <helin.zhang at intel.com>
>


More information about the dev mailing list