[dpdk-dev] [PATCH 3/5] bnx2x: Add RTE_LIBRTE_BNX2X_REG_ACCESS config option

[Thomas Monjalon]

2015-10-23 22:28, Harish Patil:
> >2015-09-11 17:42, Rasesh Mody:
> >> From: Harish Patil <harish.patil at qlogic.com>
> >> --- a/config/common_linuxapp
> >> +++ b/config/common_linuxapp
> >> @@ -220,6 +220,7 @@ CONFIG_RTE_LIBRTE_BNX2X_DEBUG_INIT=n
> >>  CONFIG_RTE_LIBRTE_BNX2X_DEBUG_RX=n
> >>  CONFIG_RTE_LIBRTE_BNX2X_DEBUG_TX=n
> >>  CONFIG_RTE_LIBRTE_BNX2X_MF_SUPPORT=n
> >> +CONFIG_RTE_LIBRTE_BNX2X_REG_ACCESS=n
> >
> >Why do you need this option?
> 
> Currently logging of register accesses is using (wrongly) the generic
> driver debug option of PMD_DRV_LOG (which gets enabled if
> CONFIG_RTE_LIBRTE_BNX2X_DEBUG=y).
> This floods the console due to excessive printing of register
> reads/writes. So creating a new debug option in order to capture only the
> register read/writes (if required) and also does not interfere with the
> informational/user-level debug.

You mean there is not enough log levels?

#define RTE_LOG_EMERG    1U  /**< System is unusable.               */
#define RTE_LOG_ALERT    2U  /**< Action must be taken immediately. */
#define RTE_LOG_CRIT     3U  /**< Critical conditions.              */
#define RTE_LOG_ERR      4U  /**< Error conditions.                 */
#define RTE_LOG_WARNING  5U  /**< Warning conditions.               */
#define RTE_LOG_NOTICE   6U  /**< Normal but significant condition. */
#define RTE_LOG_INFO     7U  /**< Informational.                    */
#define RTE_LOG_DEBUG    8U  /**< Debug-level messages.             */

Either other "debug" logs can be put as INFO level, or
you need a level 9 for verbose debug.
But I don't really understand what is the problem of a verbose debug.

It is not critical for the acceptance of this patch. Just wanted to discuss
it as we have many config options to tune the debug.

Please, at least, use the DEBUG word in the option name as done for
CONFIG_RTE_LIBRTE_BNX2X_DEBUG_RX.